Thread (19 messages) 19 messages, 3 authors, 2023-04-14

Re: [PATCH 3/6] nfsd: simplify the delayed disposal list code

From: Jeff Layton <jlayton@kernel.org>
Date: 2023-01-18 19:42:30

On Wed, 2023-01-18 at 19:08 +0000, Chuck Lever III wrote:
quoted
On Jan 18, 2023, at 12:31 PM, Jeff Layton [off-list ref] wrote:

When queueing a dispose list to the appropriate "freeme" lists, it
pointlessly queues the objects one at a time to an intermediate list.

Remove a few helpers and just open code a list_move to make it more
clear and efficient. Better document the resulting functions with
kerneldoc comments.
I'd like to freeze the filecache code until we've sorted out the
destroy_deleg_unhashed crashes. Shall I simply maintain 3/6 and
4/6 and any subsequent filecache changes (like my rhltable
rewrite) on a topic branch?

One good reason to do that is to enable an eventual fix to be
backported to stable kernels without also needing to pull in
intervening clean-up patches.

I've already applied a couple small changes that I would rather
wait on for this reason. I might move those over to the topic
branch as well... I promise to keep it based on nfsd-next so it
makes sense to continue developing filecache work on top of the
topic branch.

The other patches in this series are sensible clean-ups that I
plan to apply for v6.3 if there are no other objections.
So that means you won't take patches 3 and 4, but the rest are ok?
-- 
Jeff Layton [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help