Re: [PATCH 1/2] Covscan Scan: Wrong Check of Return Value
From: Steve Dickson <hidden>
Date: 2023-01-11 15:58:12
On 1/4/23 12:08 PM, Steve Dickson wrote:
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2151966 Signed-off-by: Steve Dickson <redacted>
Committed... (tag: nfs-utils-2-6-3-rc6) steved.
quoted hunk ↗ jump to hunk
--- support/export/client.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/support/export/client.c b/support/export/client.c index ea4f89d..79164fe 100644 --- a/support/export/client.c +++ b/support/export/client.c@@ -699,6 +699,9 @@ check_netgroup(const nfs_client *clp, const struct addrinfo *ai) /* check whether the IP itself is in the netgroup */ ip = calloc(INET6_ADDRSTRLEN, 1); + if (ip == NULL) + goto out; + if (inet_ntop(ai->ai_family, &(((struct sockaddr_in *)ai->ai_addr)->sin_addr), ip, INET6_ADDRSTRLEN) == ip) { if (innetgr(netgroup, ip, NULL, NULL)) { free(hname);