Re: [PATCH] NFS: Handle missing attributes in OPEN reply
From: Trond Myklebust <trondmy@kernel.org>
Date: 2023-01-04 01:15:52
On Wed, 2023-01-04 at 12:01 +1100, NeilBrown wrote:
On Wed, 04 Jan 2023, Trond Myklebust wrote:quoted
If the server starts to reply NFS4ERR_STALE to GETATTR requests, why do we care about stateid values? Just mark the inode as stale and drop it on the floor.We have a valid state from the server - we really shouldn't just ignore it. Maybe it would be OK to mark the inode stale. I don't know if various retry loops abort properly when the inode is stale.
Yes, they are all supposed to do that. Otherwise we would end up looping forever in close(), for instance, since the PUTFH, GETATTR and CLOSE can all return NFS4ERR_STALE as well. -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@hammerspace.com