Re: nfs setgid inheritance test

On Fri, Dec 30, 2022 at 11:11:56AM +0000, cuiyue-fnst@fujitsu.com wrote:

Hi, Christian

When I test xfstests on NFS(with no_root_squash), generic/633 fails like this:

generic/633       [failed, exit status 1]- output mismatch (see /var/lib/xfstests/results//generic/633.out.bad)
    --- tests/generic/633.out     2022-11-23 09:13:48.919484895 -0500
    +++ /var/lib/xfstests/results//generic/633.out.bad   2022-11-24 05:53:40.836484895 -0500
    @@ -1,2 +1,4 @@
     QA output created by 633
     Silence is golden
    +vfstest.c: 1642: setgid_create - Success - failure: is_setgid
    +vfstest.c: 1882: run_test - Operation not supported - failure: create operations in directories with setgid bit set
    ...
    (Run 'diff -u /var/lib/xfstests/tests/generic/633.out /var/lib/xfstests/results//generic/633.out.bad'  to see the entire diff)

We have reported this problem on Feburary.
https://lore.kernel.org/linux-nfs/OS3PR01MB770539462BE3E7959DAF8B5789389@OS3PR01MB7705.jpnprd01.prod.outlook.com/T/#u (local)

At that time, the conclusion is NFS should skip this test.
But I cannot find this patch in the latest xfstests.
Does NFS still need to skip this test now?

Afaict, nothing has changed and the test should still be skipped.
I'm not sure I ever send a patch to skip this test specifically for nfs
though. I might just not have gotten around to that.

Can you please also send the exact steps for reproducing this issue?