On Tue, Jul 19, 2022 at 10:10 AM Chuck Lever III [off-list ref] wrote:

quoted

On Jul 18, 2022, at 11:51 PM, Christoph Hellwig [off-list ref] wrote:

On Mon, Jul 18, 2022 at 10:00:12AM -0400, Chuck Lever wrote:

quoted

Clean up: I cannot find CONFIG_SUNRPC_GSS_MODULE anywhere.

CONFIG_SUNRPC_GSS_MODULE is set if SUNRPC_GSS is built as a module.
CONFIG_*_MODULE is Kconfig-generated magic.

I can drop this patch, but I still have questions (and I know you are
just the messenger, you might not know the answers).

Where is this convention documented?

When would CONFIG_SUNRPC_GSS_MODULE be defined but CONFIG_SUNRPC_GSS isn't?

There is a macro "IS_ENABLED()" that evaluates as true if something is
either compiled in or compiled as a module. That's probably what you
want to change the "#if defined()" options to.

Anna

--
Chuck Lever