Thread (5 messages) 5 messages, 3 authors, 2021-09-21

Re: [RFC PATCH] fscache, 9p, afs, cifs, nfs: Deal with some warnings from W=1

From: Matthew Wilcox <willy@infradead.org>
Date: 2021-09-20 12:39:33
Also in: linux-cifs, linux-doc, linux-fsdevel, lkml

On Mon, Sep 20, 2021 at 01:14:15PM +0100, David Howells wrote:
quoted hunk ↗ jump to hunk
+++ b/fs/9p/vfs_addr.c
@@ -88,7 +88,7 @@ static const struct netfs_read_request_ops v9fs_req_ops = {
 
 /**
  * v9fs_vfs_readpage - read an entire page in from 9P
- * @filp: file being read
+ * @file: file being read
  * @page: structure to page
  *
  */
This is an example of a weird pattern in filesystems.  Several of
them have kernel-doc for the implementation of various ->ops methods.
I don't necessarily believe we should delete the comments (although is
there any useful information in the above?), but I don't see the point
in the comment being kernel-doc.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help