Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices
From: Amir Goldstein <amir73il@gmail.com>
Date: 2021-02-18 09:59:17
Also in:
ceph-devel, linux-cifs, linux-fsdevel, lkml
Possibly related (same subject, not in this thread)
- 2021-02-18 · Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices · Amir Goldstein <amir73il@gmail.com>
- 2021-02-18 · Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices · Luis Henriques <hidden>
- 2021-02-18 · Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices · Luis Henriques <hidden>
- 2021-02-18 · Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices · "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
- 2021-02-18 · Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices · Andreas Dilger <hidden>
On Thu, Feb 18, 2021 at 9:42 AM Christoph Hellwig [off-list ref] wrote:
Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de> This whole idea of cross-device copie has always been a horrible idea, and I've been arguing against it since the patches were posted.
Ok. I'm good with this v2 as well, but need to add the fallback to do_splice_direct() in nfsd_copy_file_range(), because this patch breaks it. And the commit message of v3 is better in describing the reported issue. Thanks, Amir.