Re: [PATCH v5 7/7] fs: add a flag for per-operation O_DSYNC semantics
From: Jeff Moyer <hidden>
Date: 2014-11-06 23:46:08
Also in:
ceph-devel, linux-api, linux-arch, linux-fsdevel, linux-mm, lkml, ocfs2-devel
Possibly related (same subject, not in this thread)
- 2014-11-10 · Re: [PATCH v5 7/7] fs: add a flag for per-operation O_DSYNC semantics · Sage Weil <hidden>
- 2014-11-05 · [PATCH v5 7/7] fs: add a flag for per-operation O_DSYNC semantics · Milosz Tanski <hidden>
Milosz Tanski [off-list ref] writes:
- if (type == READ && (flags & RWF_NONBLOCK))
- return -EAGAIN;
+ if (type == READ) {
+ if (flags & RWF_NONBLOCK)
+ return -EAGAIN;
+ } else {
+ if (flags & RWF_DSYNC)
+ return -EINVAL;
+ }Minor nit, but I'd rather read something that looks like this: if (type == READ && (flags & RWF_NONBLOCK)) return -EAGAIN; else if (type == WRITE && (flags & RWF_DSYNC)) return -EINVAL; I won't lose sleep over it, though. Reviewed-by: Jeff Moyer <redacted>