Thread (27 messages) 27 messages, 5 authors, 2012-03-05

Re: [PATCH] Check for beginning '/' in the mount path

From: Malahal Naineni <hidden>
Date: 2012-02-03 14:31:17

NeilBrown [neilb@suse.de] wrote:
On Fri, 3 Feb 2012 13:15:12 +0200 Boaz Harrosh [off-list ref] wrote:
quoted
On 02/03/2012 03:42 AM, Malahal Naineni wrote:
quoted
NFSv4 gladly accepts and mounts "hostname:path" instead of
"hostname:/path". This causes mount entry mistmatch between /etc/mtab
and /proc/mounts files. The former will have "hostname:path" but the
latter will have "hostname:/path". This causes umount not work at all.
NACK

like it or not you are changing ABI. Bunch of systems will not work now.

Also some other NFS servers/clients support it fine. Actually some servers
make it a special case. (It's called mount by tag)

The bug is else where fix it there. Either add the preceding '/' to
/etc/mtab or remove it from /proc/mounts (I prefer the later). Or
                                            ^^^^^^^^^^^^^^^^^^
quoted
fix umount to work with that case.
Agreed.  And while we are at it we should remove the trailing '/' too.
If you
  mount host:/path /somewhere
/proc/mounts will show
    host:/path/

which also confused mount.
Thank you Neil and Boaz. Since there is already a fix in umount to take
care of trailing slash, I will post a patch to take care of leading
slash.

Any reason(s) why trailing slash is fixed in umount rather than in
/proc/mounts?

Thanks, Malahal.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help