Re: [PATCH -V6 10/26] vfs: Make the inode passed to inode_change_ok non-const
From: J. Bruce Fields <hidden>
Date: 2011-09-07 20:43:22
Also in:
linux-fsdevel, lkml
On Mon, Sep 05, 2011 at 10:55:32PM +0530, Aneesh Kumar K.V wrote:
From: Andreas Gruenbacher <agruen@kernel.org> We will need to call iop->permission and iop->get_acl from inode_change_ok() for additional permission checks, and both take a non-const inode.
OK, the essential difference being that richacls have a say in whether we can change attributes or not, which posix acls (for example) don't? --b.
quoted hunk ↗ jump to hunk
Signed-off-by: Andreas Gruenbacher <agruen@kernel.org> Signed-off-by: Aneesh Kumar K.V <redacted> --- fs/attr.c | 2 +- include/linux/fs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)diff --git a/fs/attr.c b/fs/attr.c index 538e279..f15e9e3 100644 --- a/fs/attr.c +++ b/fs/attr.c@@ -26,7 +26,7 @@ * Should be called as the first thing in ->setattr implementations, * possibly after taking additional locks. */ -int inode_change_ok(const struct inode *inode, struct iattr *attr) +int inode_change_ok(struct inode *inode, struct iattr *attr) { unsigned int ia_valid = attr->ia_valid;diff --git a/include/linux/fs.h b/include/linux/fs.h index c5c98c5..8afb054 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h@@ -2568,7 +2568,7 @@ extern int buffer_migrate_page(struct address_space *, #define buffer_migrate_page NULL #endif -extern int inode_change_ok(const struct inode *, struct iattr *); +extern int inode_change_ok(struct inode *, struct iattr *); extern int inode_newsize_ok(const struct inode *, loff_t offset); extern void setattr_copy(struct inode *inode, const struct iattr *attr);-- 1.7.4.1