Re: [PATCH] SUNRPC: Remove resource leak in svc_rdma_send_error()
From: J. Bruce Fields <hidden>
Date: 2011-03-17 18:37:59
Also in:
lkml, netdev
On Sat, Jan 22, 2011 at 10:40:20PM +0100, Jesper Juhl wrote:
We leak the memory allocated to 'ctxt' when we return after 'ib_dma_mapping_error()' returns !=0. Signed-off-by: Jesper Juhl <redacted>
I don't know this code, but I can't see how that could be wrong.... Applying unless Tom tells me otherwise. --b.
quoted hunk ↗ jump to hunk
--- svc_rdma_transport.c | 1 + 1 file changed, 1 insertion(+) compile tested onlydiff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index 9df1ead..1a10dcd 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c@@ -1335,6 +1335,7 @@ void svc_rdma_send_error(struct svcxprt_rdma *xprt, struct rpcrdma_msg *rmsgp, p, 0, length, DMA_FROM_DEVICE); if (ib_dma_mapping_error(xprt->sc_cm_id->device, ctxt->sge[0].addr)) { put_page(p); + svc_rdma_put_context(ctxt, 1); return; } atomic_inc(&xprt->sc_dma_used);-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please.