Re: [PATCH] mm: memcontrol: fix compilation

Am Montag, dem 07.09.2026 um 14:18 +0000 schrieb sashiko-bot@kernel.org:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Redundant include of <linux/irq_work.h>
--

commit e46ef07a908650625b6fdf687c2624752ae3ff9c
Author: Bert Karwatzki [off-list ref]

mm: memcontrol: fix compilation

This commit attempts to fix a compilation issue by including
<linux/irq_work.h> in mm/memcontrol.c.

quoted

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 307203301a2a5..4740f519883a3 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c

@@ -72,6 +72,7 @@
 #include "memcontrol-v1.h"
 
 #include <linux/uaccess.h>
+#include <linux/irq_work.h>

[Severity: Low]
Is this additional include necessary? I noticed that <linux/irq_work.h> is
already unconditionally included slightly earlier in this same file:

mm/memcontrol.c:
#include <linux/kmemleak.h>
#include <linux/irq_work.h>
#include "internal.h"

Yes, the include is neccessary because irq_work.h is not already include
in next-20260904.

In next-20260907 it's not included, either, but it is no longer necessary,
as mm/memcontrol.c no longer use struct irq_work_queue.



Bert Karwatzki