Re: [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-10-28 09:25:36
Also in:
linux-arm-kernel, linux-mediatek, linux-mips, linux-pci
On Thu, Oct 28, 2021 at 06:11:18AM +0200, Sergio Paracuellos wrote:
On Thu, Oct 28, 2021 at 6:05 AM Yanteng Si [off-list ref] wrote:quoted
Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver") the MT7621 PCIe host controller driver is built as a module but modpost complains once these drivers become modules. ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! Let's just export them. Signed-off-by: Yanteng Si <redacted> --- arch/mips/kernel/mips-cm.c | 5 +++++ arch/mips/kernel/mips-cpc.c | 1 + 2 files changed, 6 insertions(+)Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
could we instead make the pcie-mt761 driver non modular ? Exporting all MIPS specific stuff for just making an essential driver modular doesn't IMHO make much sense. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]