Thread (6 messages) 6 messages, 4 authors, 2021-11-09

RE: linux-next: build failure after merge of the pinctrl tree

From: Prathamesh Shete <hidden>
Date: 2021-10-28 12:31:26
Also in: lkml

Thanks Dmitry for pointing out.
Attached patch to fix the issue.
Please help apply the patch.

Thanks
Prathamesh.

-----Original Message-----
From: Dmitry Osipenko <digetx@gmail.com> 
Sent: Wednesday, October 27, 2021 2:51 AM
To: Prathamesh Shete <redacted>; Stephen Rothwell <redacted>; Linus Walleij <redacted>
Cc: Kartik . <redacted>; Linux Kernel Mailing List <redacted>; Linux Next Mailing List <redacted>
Subject: Re: linux-next: build failure after merge of the pinctrl tree

External email: Use caution opening links or attachments


26.10.2021 15:30, Prathamesh Shete пишет:
Fixed following warnings and error.
Attached the patch that fixes the issue.
Please help apply the Patch.

Thanks
Prathamesh.

-----Original Message-----
From: Stephen Rothwell <redacted>
Sent: Tuesday, October 26, 2021 10:59 AM
To: Linus Walleij <redacted>
Cc: Kartik . <redacted>; Prathamesh Shete 
[off-list ref]; Linux Kernel Mailing List 
[off-list ref]; Linux Next Mailing List 
[off-list ref]
Subject: linux-next: build failure after merge of the pinctrl tree

Hi all,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_get_group':
drivers/pinctrl/tegra/pinctrl-tegra.c:293:12: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  293 |     return &pmx->soc->groups[group];
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra.c:282:25: warning: unused variable 'g' [-Wunused-variable]
  282 |  struct tegra_pingroup *g;
      |                         ^
drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_gpio_disable_free':
drivers/pinctrl/tegra/pinctrl-tegra.c:341:10: error: 'return' with a value, in function returning void [-Werror=return-type]
  341 |   return -EINVAL;
      |          ^
drivers/pinctrl/tegra/pinctrl-tegra.c:327:13: note: declared here
  327 | static void tegra_pinctrl_gpio_disable_free(struct pinctrl_dev *pctldev,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  a42c7d95d29e ("pinctrl: tegra: Use correct offset for pin group")

I have used the pinctrl tree from next-20211025 for today.
The tegra_pinctrl_get_group() should return const and not cast the pointers. Please make another patch to fix it properly.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help