Thread (9 messages) 9 messages, 3 authors, 2021-10-20

Re: linux-next: Tree for Oct 18 ('make' error on ARCH=um)

From: Miguel Ojeda <hidden>
Date: 2021-10-18 22:19:02
Also in: linux-kbuild, linux-um, lkml

On Mon, Oct 18, 2021 at 11:58 PM Stephen Rothwell [off-list ref] wrote:
In commit

  c862c7fee526 ("Kbuild: add Rust support")

from the rust tree, these bits should probably not be there:

-ifneq ($(findstring clang,$(CC_VERSION_TEXT)),)
 include $(srctree)/scripts/Makefile.clang
-endif
So this was on purpose -- we need the Clang flags even in GCC builds
for bindgen. But now there is that `$(error ...)` added there :(
Miguel, does that seem reasonable?
Of course, for today please feel free to apply your fix (i.e. to put
the conditional back to where it was). I will solve it on my side
tomorrow.

Cheers,
Miguel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help