Re: linux-next: build failure after merge of the akpm-current tree
From: Andy Shevchenko <hidden>
Date: 2021-10-18 08:02:27
Also in:
lkml
On Mon, Oct 18, 2021 at 6:49 AM Stephen Rothwell [off-list ref] wrote:
On Fri, 15 Oct 2021 16:14:56 +0300 Andy Shevchenko [off-list ref] wrote:quoted
Thanks! As a quick fix looks good, but I think we need a separate header for those _*_IP_ macros.Like this (on top of my previous fix - which I assume Andrew will squash out of existence)?
Yep, thanks! I thought that it makes sense to have STACK_MAGIC also in this header. Thoughts? One spelling correction below.
From: Stephen Rothwell <redacted> Date: Mon, 18 Oct 2021 13:27:54 +1100 Subject: [PATCH] kernel.h: split out instrcutions pointer accessors
instructions
quoted hunk ↗ jump to hunk
botton_half.h needs _THIS_IP_ to be standalone, so split that and _RET_IP_ out from kernel.h into the new instruction_pointer.h. kernel.h directly needs them, so include it there and replace the include of kernel.h with this new file in bottom_half.h. Signed-off-by: Stephen Rothwell <redacted> --- include/linux/bottom_half.h | 2 +- include/linux/instruction_pointer.h | 8 ++++++++ include/linux/kernel.h | 4 +--- 3 files changed, 10 insertions(+), 4 deletions(-) create mode 100644 include/linux/instruction_pointer.hdiff --git a/include/linux/bottom_half.h b/include/linux/bottom_half.h index 11d107d88d03..fc53e0ad56d9 100644 --- a/include/linux/bottom_half.h +++ b/include/linux/bottom_half.h@@ -2,7 +2,7 @@ #ifndef _LINUX_BH_H #define _LINUX_BH_H -#include <linux/kernel.h> +#include <linux/instruction_pointer.h> #include <linux/preempt.h> #if defined(CONFIG_PREEMPT_RT) || defined(CONFIG_TRACE_IRQFLAGS)diff --git a/include/linux/instruction_pointer.h b/include/linux/instruction_pointer.h new file mode 100644 index 000000000000..19e979425bda --- /dev/null +++ b/include/linux/instruction_pointer.h@@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_INSTRUCTION_POINTER_H +#define _LINUX_INSTRUCTION_POINTER_H + +#define _RET_IP_ (unsigned long)__builtin_return_address(0) +#define _THIS_IP_ ({ __label__ __here; __here: (unsigned long)&&__here; }) + +#enfif /* _LINUX_INSTRUCTION_POINTER_H */diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 973c61ff2ef9..be84ab369650 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h@@ -20,6 +20,7 @@ #include <linux/printk.h> #include <linux/build_bug.h> #include <linux/static_call_types.h> +#include <linux/instruction_pointer.h> #include <asm/byteorder.h> #include <uapi/linux/kernel.h>@@ -53,9 +54,6 @@ } \ ) -#define _RET_IP_ (unsigned long)__builtin_return_address(0) -#define _THIS_IP_ ({ __label__ __here; __here: (unsigned long)&&__here; }) - /** * upper_32_bits - return bits 32-63 of a number * @n: the number we're accessing --2.33.0 There are, presumably, other places this new file can be included ... -- Cheers, Stephen Rothwell
-- With Best Regards, Andy Shevchenko