Thread (3 messages) 3 messages, 2 authors, 2021-05-26

Re: [PATCH] m68k: Drop duplicate "core-y += arch/m68k/" rule causing link failures

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-05-26 14:51:51
Also in: linux-m68k, lkml

Hi Yamada-san,

On Wed, May 26, 2021 at 4:24 PM Masahiro Yamada [off-list ref] wrote:
On Wed, May 26, 2021 at 5:45 PM Geert Uytterhoeven [off-list ref] wrote:
quoted
    Makefile:1949: target 'arch/m68k' given more than once in the same rule
    [...]
      LD      vmlinux.o
    m68k-linux-gnu-ld: arch/m68k/kernel/entry.o: in function `system_call':
    (.text+0x160): multiple definition of `system_call'; arch/m68k/kernel/entry.o:(.text+0x160): first defined here
    [...]

All "core-y += arch/<arch>/" rules were dropped from the corresponding
arch/<arch>/Makefiles, but m68k was forgotten.

Reported-by: noreply@ellerman.id.au
Fixes: 7d9677835b10b5de ("kbuild: require all architectures to have arch/$(SRCARCH)/Kbuild")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
I will squash this.
Fine for me. Thx!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help