Thread (4 messages) flat view 4 messages, 3 authors, 2021-03-02

Re: linux-next: build failure after merge of the powerpc-fixes tree

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2021-03-02 23:36:13
Also in: linuxppc-dev, lkml

Uwe Kleine-König [off-list ref] writes:
Hello,

On 3/2/21 3:09 AM, Michael Ellerman wrote:
quoted
Stephen Rothwell [off-list ref] writes:
quoted
Hi all,

After merging the powerpc-fixes tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/ibm/ibmvnic.c:5399:13: error: conflicting types for 'ibmvnic_remove'
  5399 | static void ibmvnic_remove(struct vio_dev *dev)
       |             ^~~~~~~~~~~~~~
drivers/net/ethernet/ibm/ibmvnic.c:81:12: note: previous declaration of 'ibmvnic_remove' was here
    81 | static int ibmvnic_remove(struct vio_dev *);
       |            ^~~~~~~~~~~~~~

Caused by commit

   1bdd1e6f9320 ("vio: make remove callback return void")
Gah, is IBMVNIC in any of our defconfigs?! ... no it's not.
Would you accept a patch to add the driver to one of the defconfigs as 
an excuse for the build breakage I created?
Thanks, but I already sent a patch adding it.

We should really have these drivers enabled in our defconfig, so that's
on us.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help