Thread (4 messages) 4 messages, 3 authors, 2021-02-05

Re: [PATCH] xfs: fix unused variable build warning in xfs_log.c

From: "Darrick J. Wong" <djwong@kernel.org>
Date: 2021-02-05 03:31:15
Also in: linux-xfs, lkml

On Thu, Feb 04, 2021 at 07:18:14PM -0800, John Hubbard wrote:
Delete the unused "log" variable in xfs_log_cover().

Fixes: 303591a0a9473 ("xfs: cover the log during log quiesce")
Cc: Brian Foster <redacted>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Darrick J. Wong <djwong@kernel.org>
Cc: Allison Henderson <redacted>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
Hi,

I just ran into this on today's linux-next, so here you go!
Thanks for the tipoff, I just realized with horror that I got the git
push wrong and never actually updated xfs-linux.git#for-next.  This (and
all the other gcc warnings) are fixed in "xfs-for-next" which ... is not
for-next.

Sigh.....  so much for trying to get things in for testing. :(

--D
quoted hunk ↗ jump to hunk
thanks,
John Hubbard
NVIDIA

 fs/xfs/xfs_log.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 58699881c100..5a9cca3f7cbf 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -1108,7 +1108,6 @@ static int
 xfs_log_cover(
 	struct xfs_mount	*mp)
 {
-	struct xlog		*log = mp->m_log;
 	int			error = 0;
 	bool			need_covered;
 
base-commit: 0e2c50f40b7ffb73a039157f7c38495c6d99e86f
-- 
2.30.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help