Thread (16 messages) 16 messages, 5 authors, 2020-06-29

Re: linux-next: build failure after merge of the printk tree

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2020-06-24 08:22:00
Also in: lkml

On Wed, Jun 24, 2020 at 10:19:29AM +0200, Petr Mladek wrote:
On Wed 2020-06-24 10:20:58, Herbert Xu wrote:
quoted
On Tue, Jun 23, 2020 at 04:28:58PM +0200, Petr Mladek wrote:
quoted
It is similar cycle:

spinlock_types.h -> lockdep.h -> printk.h -> ratelimit.h -> spinlock_types.h

But this time it happens via list.h -> kernel.h ->printk.h.
Where list.h needs READ_ONCE() stuff from compiler.h.
But this is exactly the loop that's fixed by the lockdep_types
patch.
I think that this problem is similar to the one on s390 that was
solved by compiler.h in arch/s390/include/asm/bug.h

It is related to
https://lore.kernel.org/r/20200613142901.65xieioomt6bbqa6@ltop.local (local)

It seems that we need the same change also in list.h.
Oh I see.  I misunderstood what you said in the first email.
 
Do you mean to repost the 2nd patch with the change in
include/linux/list.h?
OK let me test this and repost.

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help