Re: [XFS][trinity] WARNING: CPU: 32 PID: 31369 at fs/iomap.c:993
From: Jens Axboe <axboe@kernel.dk>
Date: 2017-09-18 15:51:35
Also in:
linux-xfs, linuxppc-dev, lkml
On 09/18/2017 09:43 AM, Al Viro wrote:
On Mon, Sep 18, 2017 at 05:39:47PM +0200, Christoph Hellwig wrote:quoted
On Mon, Sep 18, 2017 at 09:28:55AM -0600, Jens Axboe wrote:quoted
If it's expected, why don't we kill the WARN_ON_ONCE()? I get it all the time running xfstests as well.Dave insisted on it to decourage users/applications from mixing mmap and direct I/O. In many ways a tracepoint might be the better way to diagnose these.sysctl suppressing those two, perhaps?
I'd rather just make it a trace point, but don't care too much. The code doesn't even have a comment as to why that WARN_ON() is there or expected. Seems pretty sloppy to me, not a great way to "discourage" users to mix mmap/dio. -- Jens Axboe