Thread (1 message) 1 message, 1 author, 2017-01-13

Re: linux-next: build warning after merge of the wireless-drivers-next tree

From: Kalle Valo <hidden>
Date: 2017-01-13 13:47:54
Also in: linux-wireless, lkml

Possibly related (same subject, not in this thread)

Stephen Rothwell [off-list ref] writes:
Hi all,

After merging the wireless-drivers-next tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:

drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pcie_remove':
drivers/net/wireless/marvell/mwifiex/pcie.c:303:5: warning: 'fw_status' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (fw_status == FIRMWARE_READY_PCIE && !adapter->mfg_mode) {
     ^

Introduced by commit

  045f0c1b5e26 ("mwifiex: get rid of global user_rmmod flag")

This is not a false positive since "reg" could be NULL just above
(otherwise it would be tested for).
Thanks, I noticed this myself yesterday (after I had applied the patch)
and I have asked Marvell to send a fix.

-- 
Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help