Thread (1 message) 1 message, 1 author, 2016-06-09

Re: [PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2016-06-09 06:43:24
Also in: linux-wireless, lkml

On Thu, 2016-06-09 at 11:06 +0530, Prasun Maiti wrote:
quoted hunk
Since add more warnings for inconsistent ops in cfg80211, the
wireless
core warns if a driver implements a cfg80211 callback but doesn't
implements the inverse operation. The ath6kl driver implements a
cfg80211
.get_antenna operation handler but doesn't have the inverse
.set_antenna
callback. So, it makes warning.

To remove this warning, add .set_antenna callback in ath6kl driver
which
is unimplemented.

Signed-off-by: Prasun Maiti <redacted>
---
 drivers/net/wireless/ath/ath6kl/cfg80211.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c
b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 4e11ba0..e638296 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -3231,6 +3231,16 @@ static int ath6kl_mgmt_tx(struct wiphy *wiphy,
struct wireless_dev *wdev,
 					wait, buf, len, no_cck);
 }
 
+static int ath6kl_set_antenna(struct wiphy *wiphy,
+				u32 tx_ant, u32 rx_ant)
+{
+	/*
+	 * Note: This callback should be implement when firmware
support this
+	 * command.
+	 */
+	return 0;
+}
Seriously, this makes no sense at all. Just submit a patch to remove
the warning.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help