Thread (2 messages) 2 messages, 2 authors, 2016-03-31

linux-next: build failure after merge of the gpio tree

From: Stephen Rothwell <hidden>
Date: 2016-03-31 02:22:39
Also in: lkml
Subsystem: linux for powerpc (32-bit and 64-bit), the rest · Maintainers: Madhavan Srinivasan, Michael Ellerman, Linus Torvalds

Hi Linus,

After merging the gpio tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

arch/powerpc/sysdev/ppc4xx_gpio.c: In function 'ppc4xx_gpio_set':
arch/powerpc/sysdev/ppc4xx_gpio.c:93:26: error: unused variable 'mm_gc' [-Werror=unused-variable]
  struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
                          ^
cc1: all warnings being treated as errors

Caused by commit

  0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")

I applied this patch for today:

From: Stephen Rothwell <redacted>
Date: Thu, 31 Mar 2016 13:18:45 +1100
Subject: [PATCH] powerpc: ppc4xx: remove unused local variable

Fixes: 0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")
Signed-off-by: Stephen Rothwell <redacted>
---
 arch/powerpc/sysdev/ppc4xx_gpio.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/sysdev/ppc4xx_gpio.c b/arch/powerpc/sysdev/ppc4xx_gpio.c
index 4ab83cd04785..5382d04dd872 100644
--- a/arch/powerpc/sysdev/ppc4xx_gpio.c
+++ b/arch/powerpc/sysdev/ppc4xx_gpio.c
@@ -90,7 +90,6 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
 static void
 ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
 {
-	struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
 	struct ppc4xx_gpio_chip *chip = gpiochip_get_data(gc);
 	unsigned long flags;
 
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help