Re: linux-next: build failure after merge of the aio tree
From: Stephen Rothwell <hidden>
Date: 2016-01-15 22:55:20
Also in:
lkml
Hi Ben, On Fri, 15 Jan 2016 10:18:21 -0500 Benjamin LaHaise [off-list ref] wrote:
On Fri, Jan 15, 2016 at 01:25:31AM -0800, Christoph Hellwig wrote:quoted
On Fri, Jan 15, 2016 at 08:23:16PM +1100, Stephen Rothwell wrote:quoted
Via the aio tree (git://git.kvack.org/~bcrl/aio-next.git#master) added in July 2013 at Ben's request. The code was added to the aio tree in Jan 12 (my time), but has never been in a published linux-next tree due to the above build problem (I back out to the previous days version of the aio tree).Well, it's code Ben posted a few days ago, which to say it mildly is rather controversial. It's cetainly not 4.5 material.It still needs the exposure.
If it is not destined for v4.5, then it should not (yet) be in linux-next. It should wait until after v4.5-rc1 is released (the merge window closes). I would also argue that if the functionality itself is still under active review (and I haven't competely followed the discussion so I don't know where that is up to, but Christoph, at least, seems not completely convinced), then it should also not yet be in linux-next.
As for the build failure, it's a bug in the arch __get_user() implementation that needs to be fixed. __get_user() should really be able to handle 64 bit types.
Yeah, it is a bit weird. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au