[Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 (Thu 10:44) Javier Martinez Canillas wrote:

Hello Lee,

On 06/25/2015 10:38 AM, Lee Jones wrote:

quoted

On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:

quoted

A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:

(MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)

This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
that dependency was removed since there isn't a reason why the option can
not be selected on other architectures. So now the above warning will not
happen and the MFD_CROS_EC dependency can be removed since is not needed.

Signed-off-by: Javier Martinez Canillas <redacted>
---

 drivers/mfd/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Applied for v4.3, thanks.

Thanks a lot.

Olof,

Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
Since both patches 1/3 and 2/3 are needed to fix the build warning for
!X86 and !ARM architectures.

Hi all,

Wondering if this fell through the cracks.  It used to be just a
linux-next issue, but now it is a mainline issue.  This _really_ should
be fixed and fed to Linus ASAP.  Ideally it should have been fixed before 
going to mainline as it was reported in plenty of time ; that is the
whole point of linux-next.... to fix unanticipated fallout and revise.

------------------
paul@builder:~/git/linux-head$ git describe 
v4.2-rc3
paul@builder:~/git/linux-head$ echo $ARCH
sparc64
paul@builder:~/git/linux-head$ make allyesconfig
scripts/kconfig/conf  --allyesconfig Kconfig
warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
#
# configuration written to .config
#
paul@builder:~/git/linux-head$ 
------------------

Thanks,
Paul.
--

Best regards,
Javier