Re: [PATCH -next] ARC: Fix earlycon build breakage
From: Vineet Gupta <hidden>
Date: 2015-02-04 05:16:20
Also in:
lkml
On Wednesday 04 February 2015 06:39 AM, Peter Hurley wrote:
Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
breaks arc:defconfig build:
drivers/built-in.o: In function `of_setup_earlycon':
(.init.text+0xb3e): undefined reference to `arc_early_base_baud'
drivers/built-in.o: In function `setup_earlycon':
(.init.text+0xcd0): undefined reference to `arc_early_base_baud'
make: *** [vmlinux] Error 1
BASE_BAUD is only required for earlycon, which should depend on
CONFIG_SERIAL_EARLYCON.
Reported-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Peter Hurley <redacted>/Me slaps myself :-( Thx for the quick fix Peter. Now applied to my for-next and also quickly tested on simulator. FWIW, the issue came about because defconfig doesn't use the 8250 uart driver, rather the legacy arc uart which still uses earlycon - but I still can't fathom why i didn't see it earlier. Thx, -Vineet
quoted hunk ↗ jump to hunk
--- arch/arc/kernel/devtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c index 5036d4c..e32b54a 100644 --- a/arch/arc/kernel/devtree.c +++ b/arch/arc/kernel/devtree.c@@ -17,7 +17,7 @@ #include <asm/clk.h> #include <asm/mach_desc.h> -#ifdef CONFIG_SERIAL_8250_CONSOLE +#ifdef CONFIG_SERIAL_EARLYCON static unsigned int __initdata arc_base_baud;