Re: mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test'
From: Guenter Roeck <linux@roeck-us.net>
Date: 2015-01-23 20:33:46
Also in:
linux-fsdevel, linux-mm, lkml
On 01/23/2015 12:20 PM, Christoph Lameter wrote:
On Fri, 23 Jan 2015, Johannes Weiner wrote:quoted
struct mem_cgroup_tree_per_node *rtpn; struct mem_cgroup_tree_per_zone *rtpz; - int tmp, node, zone; + int node, zone; for_each_node(node) {Do for_each_online_node(node) { instead?
Wouldn't that have unintended consequences ? So far rb tree nodes are allocated even if a node not online; the above would change that. Are you saying it is unnecessary to initialize rb tree nodes if the node is not online ? Not that I have any idea what is correct, it just seems odd that the existing code would do all this allocation if it is not necessary. Guenter