Thread (3 messages) 3 messages, 2 authors, 2014-11-18

Re: [PATCH] ARM: vfp: Silence mvfr0 unused variable warning

From: Stephen Rothwell <hidden>
Date: 2014-11-18 21:15:10
Also in: linux-arm-kernel, lkml

Hi Stephen,

On Tue, 18 Nov 2014 12:56:31 -0800 Stephen Boyd [off-list ref] wrote:
Stephen Rothwell reports that commit 3f4c9f8f0a20 ("ARM: 8197/1:
vfp: Fix VFPv3 hwcap detection on CPUID based cpus") introduced an
unused variable warning.

arch/arm/vfp/vfpmodule.c: In function 'vfp_init':
arch/arm/vfp/vfpmodule.c:725:6: warning: unused variable 'mvfr0'
[-Wunused-variable]
  u32 mvfr0;

Silence this warning by using IS_ENABLED instead of ifdefs.

Reported-by: Stephen Rothwell <redacted>
Signed-off-by: Stephen Boyd <redacted>
Looks good (though I haven't tested it).  One small nit below:
+		if (IS_ENABLED(CONFIG_VFPv3)) {
+			mvfr0 = fmrx(MVFR0);
Now that you have a block here, you could move the declaration of mvfr0
into this block, right?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Attachments

  • (unnamed) [application/pgp-signature] 819 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help