Thread (8 messages) 8 messages, 4 authors, 2014-11-26

linux-next: build failure after merge of the omap_dss2 tree

From: Stephen Rothwell <hidden>
Date: 2014-11-17 08:09:20
Also in: lkml
Subsystem: framebuffer layer, the rest · Maintainers: Helge Deller, Linus Torvalds

Hi Tomi,

After merging the omap_dss2 tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/video/fbdev/simplefb.c: In function 'simplefb_clocks_init':
drivers/video/fbdev/simplefb.c:207:2: error: implicit declaration of function 'of_clk_get_parent_count' [-Werror=implicit-function-declaration]
  par->clk_count = of_clk_get_parent_count(np);
  ^

Caused by commit fc219bfd5b2e ("simplefb: add clock handling code").
This build does not have CONFIG_COMMON_CLK set.

I have added the following fix for today (there is probably a better
one):

From: Stephen Rothwell <redacted>
Date: Mon, 17 Nov 2014 19:05:42 +1100
Subject: [PATCH] simplefb: make it depend on CONFIG_COMMON_CLK

Signed-off-by: Stephen Rothwell <redacted>
---
 drivers/video/fbdev/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 025b439d4fe1..1f0298e166c3 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2457,6 +2457,7 @@ config FB_HYPERV
 config FB_SIMPLE
 	bool "Simple framebuffer support"
 	depends on (FB = y)
+	depends on COMMON_CLK
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-- 
2.1.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Attachments

  • (unnamed) [application/pgp-signature] 819 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help