Thread (6 messages) 6 messages, 4 authors, 2014-11-14

Re: randconfig build error with next-20141113, in fs/pstore/inode.c

From: Sebastian Schmidt <hidden>
Date: 2014-11-14 05:09:47
Also in: lkml

Hi all,

On Thu, Nov 13, 2014 at 11:21:18AM -0800, Kees Cook wrote:
quoted
This looks to come from your "Honor dmesg_restrict sysctl on dmesg dumps" patch
Oops, you are right.
quoted
The randconfig doesn't have CONFIG_PRINTK.  I guess we need to provide a stub
in <linux/syslog.h> to cover this.
Without CONFIG_PRINTK, check_syslog_permissions should probably fail.
Kees, I disagree. Without CONFIG_PRINTK, there isn't even a
dmesg_restrict sysctl, so there is no way to turn that on (AFAICS) and
we should retain the default behaviour.

I'll send a patch shortly.

Sebastian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help