Re: [PATCH -next v3] thermal: fix x86_pkg_temp_thermal.c build and Kconfig
From: Zhang Rui <rui.zhang@intel.com>
Date: 2013-06-17 23:28:49
Also in:
linux-pm, lkml
On Mon, 2013-06-17 at 21:45 +0200, Borislav Petkov wrote:
On Mon, Jun 17, 2013 at 12:27:17PM -0700, Randy Dunlap wrote:quoted
From: Randy Dunlap <redacted> Fix build error in x86_pkg_temp_thermal.c. It requires that X86_MCE & X86_THERMAL_VECTOR be enabled, so depend on the latter symbol, since it depends on X86_MCE (indirectly). Also, X86_PKG_TEMP_THERMAL is already inside an "if THERMAL" block, so remove that duplicated dependency. ERROR: "platform_thermal_package_rate_control" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined! ERROR: "platform_thermal_package_notify" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined! Signed-off-by: Randy Dunlap <redacted> --- drivers/thermal/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)--- linux-next-20130617.orig/drivers/thermal/Kconfig +++ linux-next-20130617/drivers/thermal/Kconfig@@ -171,8 +171,7 @@ config INTEL_POWERCLAMP config X86_PKG_TEMP_THERMAL tristate "X86 package temperature thermal driver" - depends on THERMAL - depends on X86 + depends on X86_THERMAL_VECTOR select THERMAL_GOV_USER_SPACE default m helpAcked-by: Borislav Petkov <redacted>
applied to thermal -next. thanks, rui