Thread (10 messages) 10 messages, 4 authors, 2012-11-28

Re: [PATCH -next] staging/fwserial: Fix build breakage when !CONFIG_BUG

From: Randy Dunlap <hidden>
Date: 2012-11-27 18:42:28
Also in: lkml

On 11/26/2012 11:11 PM, Peter Hurley wrote:
Use WARN() as intended.

Signed-off-by: Peter Hurley <redacted>

Reported-by: Randy Dunlap <redacted>
Acked-by: Randy Dunlap <redacted>

Thanks.
quoted hunk ↗ jump to hunk
---
 drivers/staging/fwserial/dma_fifo.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/fwserial/dma_fifo.c b/drivers/staging/fwserial/dma_fifo.c
index 72aa053..5e84634 100644
--- a/drivers/staging/fwserial/dma_fifo.c
+++ b/drivers/staging/fwserial/dma_fifo.c
@@ -33,10 +33,7 @@
 
 #define FAIL(fifo, condition, format...) ({				\
 	fifo->corrupt = !!(condition);					\
-	if (unlikely(fifo->corrupt)) {					\
-		__WARN_printf(format);					\
-	}								\
-	unlikely(fifo->corrupt);					\
+	WARN(fifo->corrupt, format);					\
 })
 
 /*


-- 
~Randy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help