Thread (5 messages) 5 messages, 4 authors, 2012-11-26

Re: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled

From: Samuel Ortiz <hidden>
Date: 2012-11-26 21:07:38
Also in: lkml

Hi Randy,

On Mon, Nov 26, 2012 at 11:21:33AM -0800, Randy Dunlap wrote:
On 11/13/2012 05:35 AM, Linus Walleij wrote:
quoted
On Mon, Nov 12, 2012 at 6:20 PM, Randy Dunlap [off-list ref] wrote:
quoted
From: Randy Dunlap <redacted>

Fix build errors when CONFIG_OF is not enabled by including
<linux/of.h> (needs to be added in any case).
An alternative fix could be to make the driver depend on OF.

drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token

Signed-off-by: Randy Dunlap <redacted>
Cc: Rabin Vincent <redacted>
Cc: Samuel Ortiz <redacted>
Acked-by: Linus Walleij <redacted>



ping?

This patch is still needed in linux-next.
Applied and pushed, thanks a lot.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help