Thread (7 messages) 7 messages, 5 authors, 2012-10-24

Re: mmotm 2012-10-22-17-08 uploaded (memory_hotplug.c)

From: David Rientjes <rientjes@google.com>
Date: 2012-10-24 22:32:33
Also in: linux-mm, lkml

On Tue, 23 Oct 2012, Michal Hocko wrote:
From e8d79e446b00e57c195c59570df0f2ec435ca39d Mon Sep 17 00:00:00 2001
From: Michal Hocko <redacted>
Date: Tue, 23 Oct 2012 11:07:11 +0200
Subject: [PATCH] mm: make zone_pcp_reset independ on MEMORY_HOTREMOVE

340175b7 (mm/hotplug: free zone->pageset when a zone becomes empty)
introduced zone_pcp_reset and hided it inside CONFIG_MEMORY_HOTREMOVE.
Since "memory-hotplug: allocate zone's pcp before onlining pages" the
function is also called from online_pages which is defined outside
CONFIG_MEMORY_HOTREMOVE which causes a linkage error.

The function, although not used outside of MEMORY_{HOTPLUT,HOTREMOVE},
seems like universal enough so let's keep it at its current location
and only remove the HOTREMOVE guard.

Signed-off-by: Michal Hocko <redacted>
Reviewed-by: Wen Congyang <redacted>
Cc: David Rientjes <rientjes@google.com>
Cc: Jiang Liu <redacted>
Cc: Len Brown <redacted>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <redacted>
Cc: Christoph Lameter <redacted>
Cc: Minchan Kim <redacted>
Cc: KOSAKI Motohiro <redacted>
Cc: Yasuaki Ishimatsu <redacted>
Cc: Dave Hansen <redacted>
Cc: Mel Gorman <redacted>
Acked-by: David Rientjes <rientjes@google.com>

This fixes the build error on linux-next of this morning, thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help