Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
From: Michal Nazarewicz <hidden>
Date: 2012-10-24 17:31:56
Also in:
lkml
On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote:
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Date: Wed, 24 Oct 2012 16:40:10 +0200 found by randconfig, Randy Dunlap and Stephen Rothwell: |drivers/built-in.o: In function `fsg_setup': |file_storage.c:(.text+0x24db7c): undefined reference to `usb_gadget_config_buf' |file_storage.c:(.text+0x24db98): undefined reference to `usb_gadget_get_string' |drivers/built-in.o: In function `fsg_bind': |file_storage.c:(.init.text+0xee42): undefined reference to `usb_ep_autoconfig_reset' |file_storage.c:(.init.text+0xee51): undefined reference to `usb_ep_autoconfig' |file_storage.c:(.init.text+0xee73): undefined reference to `usb_ep_autoconfig' |file_storage.c:(.init.text+0xee9e): undefined reference to `usb_ep_autoconfig' Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
At first it looks strange as FSG does not use composite, but yeah: Acked-by: Michal Nazarewicz <redacted>
quoted hunk ↗ jump to hunk
--- for v3.7 please. drivers/usb/gadget/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index bbcec83..66bc3ab 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig@@ -737,6 +737,7 @@ config USB_FUNCTIONFS_GENERIC config USB_FILE_STORAGE tristate "File-backed Storage Gadget (DEPRECATED)" + select USB_LIBCOMPOSITE depends on BLOCK help The File-backed Storage Gadget acts as a USB Mass Storage
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--