Thread (7 messages) 7 messages, 3 authors, 2012-10-24

Re: linux-next: build failure after merge of the akpm tree

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2012-10-23 20:02:38
Also in: lkml

On Tue, 23 Oct 2012 12:51:29 -0700
Joe Perches [off-list ref] wrote:
quoted
btw, what's up with printk_syslog.h?  It includes two header files which it
doesn't need but fails to include the two it *does* need: printk_log.h
and types.h.
printk_syslog.c includes kernel.h (it includes types.h)
and printk_log.h.

I think printk_syslog.h doesn't need printk_log.h
A general rule is that the header file shouldn't know or care what else
it's includer has included.  Ideally it shouldn't know or care what
else its includees have included, either.

A fun test would be

for i in *.h
	echo $i > foo.c
	make foo.o
done
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help