Re: [PATCH -next] [media] altera-stapl should depend on HAS_IOPORT
From: Geert Uytterhoeven <hidden>
Date: 2012-09-16 19:00:00
Also in:
linux-i2c, linux-um
On Sun, Sep 16, 2012 at 11:21 AM, Geert Uytterhoeven [off-list ref] wrote:
On s390:
drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write':
drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_read':
drivers/misc/altera-stapl/altera-lpt.c:40:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[6]: *** [drivers/misc/altera-stapl/altera-lpt.o] Error 1
Before commit 3969d54acd70be70e1b2a72184cba5415bf326c2 ("i2c: Make I2C
available on UML"), this was hidden because I2C depended on HAS_IOMEM, which
is a superset of HAS_IOPORT.
Signed-off-by: Geert Uytterhoeven <redacted>Apparently Arnd sent out a patch to fix this while the driver was still in staging: http://lkml.indiana.edu/hypermail/linux/kernel/1107.0/00432.html
quoted hunk
-- http://kisskb.ellerman.id.au/kisskb/buildresult/7194502/ http://kisskb.ellerman.id.au/kisskb/buildresult/7194476/ --- drivers/misc/altera-stapl/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/misc/altera-stapl/Kconfig b/drivers/misc/altera-stapl/Kconfig index 7f01d8e..c7e4c77 100644 --- a/drivers/misc/altera-stapl/Kconfig +++ b/drivers/misc/altera-stapl/Kconfig@@ -2,7 +2,7 @@ comment "Altera FPGA firmware download module" config ALTERA_STAPL tristate "Altera FPGA firmware download module" - depends on I2C + depends on I2C && HAS_IOPORT default n help An Altera FPGA module. Say Y when you want to support this tool.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds