Re: linux-next: Tree for Aug 3 (drivers/i2c/busses/i2c-i801.c)
flat view
From: Randy Dunlap <hidden>
Date: 2012-08-03 21:38:16
Also in:
linux-i2c, lkml
On 08/03/2012 12:57 PM, Jean Delvare wrote:
Hi Randy, On Fri, 03 Aug 2012 10:24:34 -0700, Randy Dunlap wrote:quoted
on x86_64: when CONFIG_GPIOLIB is not enabled: drivers/i2c/busses/i2c-i801.c: In function 'match_gpio_chip_by_label': drivers/i2c/busses/i2c-i801.c:1011:21: error: dereferencing pointer to incomplete type drivers/i2c/busses/i2c-i801.c: In function 'i801_add_mux': drivers/i2c/busses/i2c-i801.c:1028:2: error: implicit declaration of function 'gpiochip_find' drivers/i2c/busses/i2c-i801.c:1028:7: warning: assignment makes pointer from integer without a cast drivers/i2c/busses/i2c-i801.c:1047:27: error: dereferencing pointer to incomplete type drivers/i2c/busses/i2c-i801.c: In function 'match_gpio_chip_by_label': drivers/i2c/busses/i2c-i801.c:1012:1: warning: control reaches end of non-void functionGood catch, thanks for reporting. I'll fold the following in the offending patch, that should fix it:
Ack, it does. Thanks.
quoted hunk ↗ jump to hunk
--- linux-3.6-rc0.orig/drivers/i2c/busses/Kconfig 2012-08-03 21:51:51.000000000 +0200 +++ linux-3.6-rc0/drivers/i2c/busses/Kconfig 2012-08-03 21:52:18.090537018 +0200@@ -80,6 +80,7 @@ config I2C_I801 tristate "Intel 82801 (ICH/PCH)" depends on PCI select CHECK_SIGNATURE if X86 && DMI + select GPIOLIB if I2C_MUX help If you say yes to this option, support will be included for the Intel 801 family of mainboard I2C interfaces. Specifically, the following
-- ~Randy