Thread (6 messages) 6 messages, 2 authors, 2012-07-23

Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize_irq')

From: Linus Walleij <hidden>
Date: 2012-07-17 18:40:57
Also in: linux-arm-kernel, lkml

On Tue, Jul 17, 2012 at 12:39 PM, Sedat Dilek [off-list ref] wrote:
On Tue, Jul 17, 2012 at 12:21 PM, Sedat Dilek [off-list ref] wrote:
quoted
...looks like AB3100 is the *only* driver still using rand_initialize_irq()...

drivers/mfd/ab3100-core.c:939:  rand_initialize_irq(client->irq);

...but why has random.h still this...?

include/linux/random.h:51:extern void rand_initialize_irq(int irq);

Just thinking "loud"...

- Sedat -
Is this attached patch OK, Ted?
You're just deleting a line from the AB3100 driver, so I guess you're
regressing the system since that IRQ will no longer contribute
to the entropy pool?

How do we simultaneously make sure that this IRQ is still
contributing to the entropy?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help