Thread (19 messages) 19 messages, 7 authors, 2012-06-20

RE: linux-next: build failure after merge of the net-next tree

From: Bhupesh SHARMA <hidden>
Date: 2012-06-20 04:46:10
Also in: lkml, netdev

Hi David,
-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Wednesday, June 20, 2012 10:07 AM
To: Bhupesh SHARMA
Cc: sfr@canb.auug.org.au; netdev@vger.kernel.org; linux-
next@vger.kernel.org; linux-kernel@vger.kernel.org;
federico.vaga@gmail.com; Giancarlo ASNAGHI; wg@grandegger.com;
mkl@pengutronix.de
Subject: Re: linux-next: build failure after merge of the net-next tree

From: Bhupesh SHARMA <redacted>
Date: Wed, 20 Jun 2012 12:27:11 +0800
quoted
clk_get/clk_put* variants are usually used by ARM platforms.
Protecting their calls under macro 'CONFIG_HAVE_CLK' should solve the
problem.

No, we don't pepper foo.c files with crappy ifdefs.
So, whether adding a check in Kconfig for HAVE_CLK be a proper solution ?
But that will limit the compilation of this driver for only platforms which are ARM based.

One may need to support this driver on x86 like platforms also..

Regards,
Bhupesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help