Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
From: Mike Frysinger <hidden>
Date: 2012-02-28 06:06:21
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 836 bytes
From: Mike Frysinger <hidden>
Date: 2012-02-28 06:06:21
Also in:
lkml
On Monday 27 February 2012 22:17:01 James Bottomley wrote:
On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:quoted
On Monday 27 February 2012 17:03:10 James Bottomley wrote:quoted
--- a/arch/parisc/Makefile +++ b/arch/parisc/Makefile -CROSS_COMPILE := hppa64-linux-gnu- + +# if no default set, try to find the corresponding 64 bit compiler +ifeq ($(CROSS_COMPILE),) +CROSS_COMPILE := $(shell $(CC) -dumpmachine | seds/hppa-\\\(.*\\\)/hppa64-\\1-/) +endiffails when using "hppa2.0-xxx". perhaps: CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed 's/^hppa[^-]*-/hppa64-/') don't even need the ifeq check thenHow is that different from Carlos' suggestion?
sorry, but i'm not seeing any e-mails from Carlos in this thread. what is his suggestion ?
The reason it doesn't work is the same ... CROSS_COMPILE is defined to be empty.
my suggestion was purely an incremental improvement on the patch you posted. it improves two things: - detection when the default tuple is hppa2.0-xxx rather than hppa-xxx - one line for set-variable-only-when-its-unset rather than three lines -mike