Re: linux-next: build failure after merge of the nfs tree
From: Trond Myklebust <hidden>
Date: 2012-01-23 18:13:13
Also in:
linux-scsi, lkml
On Mon, 2012-01-23 at 11:39 +1100, Stephen Rothwell wrote:
quoted hunk ↗ jump to hunk
Hi Trond, After merging the nfs tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/target/iscsi/iscsi_target_configfs.c: In function 'lio_target_call_addnptotpg': drivers/target/iscsi/iscsi_target_configfs.c:214:3: error: implicit declaration of function 'in6_pton' [-Werror=implicit-function-declaration] drivers/target/iscsi/iscsi_target_configfs.c:239:3: error: implicit declaration of function 'in_aton' [-Werror=implicit-function-declaration] Presumably caused by some include file cleanup in the nfs tree (probably commit 0b5357cfc2e6 "NFS: Remove unnecessary includes from linux/nfs_fs_i.h"). I applied the following patch for today: From: Stephen Rothwell <redacted> Date: Mon, 23 Jan 2012 11:35:02 +1100 Subject: [PATCH] iscsi: in_aton needs linux/inet.h so include it directly. Fixes this error after a recent nfs cleanup: drivers/target/iscsi/iscsi_target_configfs.c: In function 'lio_target_call_addnptotpg': drivers/target/iscsi/iscsi_target_configfs.c:214:3: error: implicit declaration of function 'in6_pton' [-Werror=implicit-function-declaration] drivers/target/iscsi/iscsi_target_configfs.c:239:3: error: implicit declaration of function 'in_aton' [-Werror=implicit-function-declaration] Signed-off-by: Stephen Rothwell <redacted> --- drivers/target/iscsi/iscsi_target_configfs.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c index 3468caa..6b35b37 100644 --- a/drivers/target/iscsi/iscsi_target_configfs.c +++ b/drivers/target/iscsi/iscsi_target_configfs.c@@ -21,6 +21,7 @@ #include <linux/configfs.h> #include <linux/export.h> +#include <linux/inet.h> #include <target/target_core_base.h> #include <target/target_core_fabric.h> #include <target/target_core_fabric_configfs.h>
Hi Stephen, Yep. I believe that is identical to the patch Bryan sent to James Bottomley a few days ago. Could you please carry the above in your tree until the iscsi folks get around to fixing this? Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com