2011/12/23 Stephen Rothwell [off-list ref]:

[Just letting Rusty know]

On Fri, 23 Dec 2011 00:55:00 +0100 Carles Pey [off-list ref] wrote:

quoted

Hi all,

It failed while building today's linux-next commit 4765f871e50f0 on i686:

drivers/block/paride/bpck6.c:24: error: expected ‘=’, ‘,’, ‘;’, ‘asm’
or ‘__attribute__’ before ‘verbose’
drivers/block/paride/bpck6.c: In function ‘bpck6_connect’:
drivers/block/paride/bpck6.c:94: error: ‘verbose’ undeclared (first
use in this function)
drivers/block/paride/bpck6.c:94: error: (Each undeclared identifier is
reported only once
drivers/block/paride/bpck6.c:94: error: for each function it appears in.)
drivers/block/paride/bpck6.c: In function ‘bpck6_disconnect’:
drivers/block/paride/bpck6.c:118: error: ‘verbose’ undeclared (first
use in this function)
drivers/block/paride/bpck6.c: In function ‘bpck6_test_port’:
drivers/block/paride/bpck6.c:128: error: ‘verbose’ undeclared (first
use in this function)
drivers/block/paride/bpck6.c: In function ‘bpck6_probe_unit’:
drivers/block/paride/bpck6.c:162: error: ‘verbose’ undeclared (first
use in this function)
drivers/block/paride/bpck6.c: In function ‘bpck6_init’:
drivers/block/paride/bpck6.c:253: error: ‘verbose’ undeclared (first
use in this function)
drivers/block/paride/bpck6.c: In function ‘__check_verbose’:
drivers/block/paride/bpck6.c:266: error: ‘verbose’ undeclared (first
use in this function)
drivers/block/paride/bpck6.c:266: warning: type defaults to ‘int’ in
declaration of ‘type name’
drivers/block/paride/bpck6.c:266: warning: type defaults to ‘int’ in
declaration of ‘type name’
drivers/block/paride/bpck6.c:266: warning: type defaults to ‘int’ in
declaration of ‘type name’
drivers/block/paride/bpck6.c:266: error: size of array ‘type name’ is negative
drivers/block/paride/bpck6.c:266: warning: type defaults to ‘int’ in
declaration of ‘type name’
drivers/block/paride/bpck6.c:266: warning: type defaults to ‘int’ in
declaration of ‘type name’
drivers/block/paride/bpck6.c:266: warning: type defaults to ‘int’ in
declaration of ‘type name’
drivers/block/paride/bpck6.c: At top level:
drivers/block/paride/bpck6.c:266: error: ‘verbose’ undeclared here
(not in a function)
drivers/block/paride/bpck6.c:266: warning: type defaults to ‘int’ in
declaration of ‘type name’
make[2]: *** [drivers/block/paride/bpck6.o] Error 1
make[1]: *** [drivers/block/paride] Error 2
make: *** [drivers] Error 2

Apparently due to the change in commit a367680f90a94

Carles

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

I moved the declaration after the includes:

diff --git a/drivers/block/paride/bpck6.c b/drivers/block/paride/bpck6.c
index 16dcfa9..54cc34e 100644
--- a/drivers/block/paride/bpck6.c
+++ b/drivers/block/paride/bpck6.c

@@ -21,7 +21,6 @@


 /* PARAMETERS */
-static bool verbose; /* set this to 1 to see debugging messages and whatnot */

 #define BACKPACK_VERSION "2.0.2"

@@ -37,6 +36,7 @@ static bool verbose; /* set this to 1 to see

debugging messages and whatnot */
 #include "paride.h"


+static bool verbose; /* set this to 1 to see debugging messages and whatnot */

 #define PPCSTRUCT(pi) ((Interface *)(pi->private))


Carles