Thread (17 messages) 17 messages, 8 authors, 2011-12-11

Re: linux-next: Tree for Dec 7 (x86, not SMP)

flat view

From: Don Zickus <hidden>
Date: 2011-12-07 21:06:36
Also in: lkml
Subsystem: the rest, x86 architecture (32-bit and 64-bit) · Maintainers: Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen

On Wed, Dec 07, 2011 at 12:43:37PM -0800, Randy Dunlap wrote:
On 12/07/2011 11:42 AM, Don Zickus wrote:
quoted
On Wed, Dec 07, 2011 at 11:10:29AM -0800, Randy Dunlap wrote:
quoted
On 12/06/2011 10:12 PM, Stephen Rothwell wrote:
quoted
Hi all,

Changes since 20111206:

When CONFIG_SMP is not enabled:
(I think that's the cause, but it could be some other kconfig option.)
Yeah it doesn't seem to be that one.  I think it is CONFIG_X86_LOCAL_APIC,
but I can't quickly figure out how to disable it (it keeps getting
re-enabled somewhere).

Can you attach your .config?
Certainly. Done.
Thanks.
Ok, I was right it does depend on the local apic.  The following patch
fixed the problem for me.

Cheers,
Don 
-----8<----

From: Don Zickus <redacted>
Date: Wed, 7 Dec 2011 16:03:40 -0500
Subject: [PATCH] x86, NMI: NMI selftest depends on the local apic

The selftest doesn't work with out a local apic for now.

Reported-by: Randy Durlap <redacted>
Signed-off-by: Don Zickus <redacted>
---
 arch/x86/Kconfig.debug |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index 020a4f1..d6eea6d 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -286,7 +286,7 @@ config DEBUG_STRICT_USER_COPY_CHECKS
 
 config DEBUG_NMI_SELFTEST
 	bool "NMI Selftest"
-	depends on DEBUG_KERNEL
+	depends on DEBUG_KERNEL && X86_LOCAL_APIC
 	---help---
 	  Enabling this option turns on a quick NMI selftest to verify
 	  that the NMI behaves correctly.
-- 
1.7.6.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help