Thread (16 messages) 16 messages, 7 authors, 2011-10-06

Re: [PATCH -next] x86 mrst: fix build error when X86_MRST is not enabled

From: Alan Cox <hidden>
Date: 2011-09-30 09:10:23
Also in: lkml

quoted
This breaks Medfield so NAK

The correct behaviour should be 

INTEL_MID defined -> mrst_cpu_chip has meaning
INTEL_MID not defined -> mrst_identify_chip is 0

your change makes it 0 for Medfield which means it will crash on boot.
Randy's patch is an attempt to fix Mathias's "x86: rtc: don't register
a platform RTC device for Intel MID platforms".
NAK this.
I'm tempted to do a mass droppage, but then some of the patches might
get forever lost.
Randy's patch breaks Medfield, simply because he's seeing an incomplete
set of merges. The stuff the x86 maintainers were sent already deals with
this. It's all simply a case of waiting for the trees to get back into
sync, at which point platform/x86/mrst will get built for INTEL_MID
general case.
Could we please get some x86 maintainers on deck??
Well currently x86@kernel.org is undeliverable so that won't help you.

Alan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help