On Friday, August 19, 2011, Pihet-XID, Jean wrote:

Hi Stephen, Rafael,

On Fri, Aug 19, 2011 at 5:03 AM, Stephen Rothwell [off-list ref] wrote:

quoted

Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

In file included from include/linux/netdevice.h:34:0,
                from include/linux/icmpv6.h:173,
                from include/linux/ipv6.h:220,
                from include/net/ipv6.h:16,
                from include/linux/sunrpc/clnt.h:25,
                from include/linux/nfs_fs.h:50,
                from init/do_mounts.c:20:
include/linux/pm_qos.h: In function 'dev_pm_qos_add_request':
include/linux/pm_qos.h:123:6: warning: 'return' with no value, in function returning non-void
include/linux/pm_qos.h: In function 'dev_pm_qos_update_request':
include/linux/pm_qos.h:126:6: warning: 'return' with no value, in function returning non-void
include/linux/pm_qos.h: In function 'dev_pm_qos_remove_request':
include/linux/pm_qos.h:128:6: warning: 'return' with no value, in function returning non-void

Caused by commit b6d5b88750dc ("PM QoS: Implement per-device PM QoS
constraints").

I am really sorry about this. This build failure is indeed due to my
patch which has stubs for the !PM case.
Here is an updated patch (attached), the only change is in the stubs.

quoted

Please, please compile test with CONFIG options that your patch depends
on switched on and switched off - in this case CONFIG_PM.

Well, it is not as easy as it seems. As the patch set describes, I am
build testing for x86 and OMAP. At the moment due to config
dependencies it is _impossible_ to disable PM in the OMAP config.

Also I cannot build test every platform out there.
Do you have a procedure for build testing?

quoted

I have reverted that commit (and the followinf commit 57afcf09649c ("PM
QoS: Add global notification mechanism for device constraints")) for
today.

Can we have the updated version merged in?

Merged and pushed back.

Thanks,
Rafael