Re: linux-next: Tree for July 27 (iscsi_target) [resend/lost]

On Wed, 2011-07-27 at 10:47 -0700, Randy Dunlap wrote:

On Wed, 27 Jul 2011 14:11:51 +1000 Stephen Rothwell wrote:

quoted

Hi all,

iscsi_target_login.c:(.text+0x13d3f5): undefined reference to `iscsit_thread_get_cpumask'
iscsi_target_login.c:(.text+0x13d594): undefined reference to `iscsit_thread_get_cpumask'

kernel config file is attached.

Hi Randy,

Addressing this config with the following patch:

commit b7123c56c95dcf3cc5fbdfeaceb416699d378e08
Author: Nicholas Bellinger [off-list ref]
Date:   Wed Jul 27 20:13:22 2011 +0000

    iscsi-target: Fix CONFIG_SMP=n and CONFIG_MODULES=n build failure
    
    This patch fixes the following CONFIG_SMP=n and CONFIG_MODULES=n build
    failure, because iscsit_thread_get_cpumask() is defined as a macro in
    iscsi_target.c, but needed by iscsi_target_login.c
    
    drivers/built-in.o: In function `iscsi_post_login_handler':
    iscsi_target_login.c:(.text+0x13a315): undefined reference to `iscsit_thread_get_cpumask'
    iscsi_target_login.c:(.text+0x13a4b4): undefined reference to `iscsit_thread_get_cpumask'
    make: *** [.tmp_vmlinux1] Error 1
    
    Reported-by: Randy Dunlap [off-list ref]
    Signed-off-by: Nicholas Bellinger [off-list ref]

diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 5ae3017..8f92d0d 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c

@@ -3468,7 +3468,12 @@ static inline void iscsit_thread_check_cpumask(
 }
 
 #else
-#define iscsit_thread_get_cpumask(X) ({})
+
+void iscsit_thread_get_cpumask(struct iscsi_conn *conn)
+{
+       return;
+}
+
 #define iscsit_thread_check_cpumask(X, Y, Z) ({})
 #endif /* CONFIG_SMP */
 

Shouldn't MAINTAINERS list target-devel@vger.kernel.org ?

Adding this as well now..

Thanks!

--nab