Thread (11 messages) 11 messages, 6 authors, 2011-06-26

Re: linux-next: Tree for June 24 (mtd + of)

From: Dmitry Eremin-Solenikov <hidden>
Date: 2011-06-26 20:11:16
Also in: lkml

On 6/26/11, Artem Bityutskiy [off-list ref] wrote:
On Sun, 2011-06-26 at 00:11 -0600, Grant Likely wrote:
quoted
quoted
3.0-rc4 does not have this build error when I use the .config file with
it...
however, I think that 3.0-rc4 also does not build ofpart.ko as it
should.

Looks to me like changes in drivers/mtd/{Kconfig && Makefile} caused
this
build error.
The following commit in linux-next appears to be the culprit:

commit 1a6bc893044b961caae1c5a9c6c2065e608da427
Author: Dmitry Eremin-Solenikov [off-list ref]
Date:   Sun May 29 21:32:33 2011 +0400

    mtd: prepare to convert of_mtd_parse_partitions to partition parser

    Prepare to convert of_mtd_parse_partitions() to usual partitions
parser:
    1) Register ofpart parser
    2) Internally don't use passed device for error printing
    3) Add device_node to mtd_part_parser_data struct
    4) Move of_mtd_parse_partitions from __devinit to common text section
    5) add ofpart to the default list of partition parsers

    Signed-off-by: Dmitry Eremin-Solenikov [off-list ref]
    Signed-off-by: Artem Bityutskiy [off-list ref]

It adds a module_init() call to ofpart.c which does not work the way
that ofpart.c is linked to mtdcore.o.  Seems like that commit series
still needs work.
OK, let's ask Dmitry to take a look at this.
Yes, I've forgot about this... ofpart can be made a simple module now.
I'll send two patches in five minutes or so.

-- 
With best wishes
Dmitry

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help