Thread (2 messages) 2 messages, 2 authors, 2011-03-28

Re: [PATCH -next resend] i2c: designware-pcidrv depends on PCI

From: Baruch Siach <baruch@tkos.co.il>
Date: 2011-03-28 19:02:00
Also in: linux-i2c, lkml

Hi Randy,

On Mon, Mar 28, 2011 at 08:10:43AM -0700, Randy Dunlap wrote:
From: Randy Dunlap <redacted>

i2c-designware-pcidrv is a PCI driver and should depend on PCI.
Fixes these build errors:

drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region'
drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region'
Well, I haven't seen these PCI support patches until now, but this seems to be 
OK, so, FWIW:

Acked-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch
quoted hunk ↗ jump to hunk
Signed-off-by: Randy Dunlap <redacted>
Cc: Baruch Siach <baruch@tkos.co.il>
---
 drivers/i2c/busses/Kconfig |    1 +
 1 file changed, 1 insertion(+)
--- linux-next-20110316.orig/drivers/i2c/busses/Kconfig
+++ linux-next-20110316/drivers/i2c/busses/Kconfig
@@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM
 
 config I2C_DESIGNWARE_PCI
 	tristate "Synopsys DesignWare PCI"
+	depends on PCI
 	help
 	  If you say yes to this option, support will be included for the
 	  Synopsys DesignWare I2C adapter. Only master mode is supported.
--
-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help